Add pure Ruby fallback for bcrypt_pbkdf (enables JRuby)#39
Open
mfazekas wants to merge 1 commit into
Open
Conversation
When the C extension is unavailable (JRuby or environments without a native compiler), load a pure Ruby implementation of Blowfish/bcrypt_pbkdf instead of raising. Approximately 68x slower than the C extension but acceptable for the one-time key-decryption use case in net-ssh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the C extension is unavailable (JRuby, or any environment without a native compiler), load a pure Ruby implementation instead of failing with a
LoadError.The pure Ruby path is ~68x slower than the C extension at
rounds=4(~930ms vs ~14ms), butbcrypt_pbkdfis only used in net-ssh for decrypting encrypted Ed25519 private keys — a one-time cost at connection time — so this is acceptable.JRuby users currently hit a hardcoded
raise "BCryptPbkdf is not implemented for jruby"in net-ssh; with this change that can be removed.All existing test vectors pass under the pure Ruby implementation.