Skip to content

addresses issue where memory allocation is not freed on error state, addresses #33 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mha-gen wants to merge 2 commits into
base: main
Choose a base branch
from
Open

addresses issue where memory allocation is not freed on error state, addresses #33 #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3518fbf
fix issue #23
mha-gen Jun 10, 2026
2019421
do not leak memory on error state within bcrypt_pbkdf_ext
mha-gen Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ext/mri/bcrypt_pbkdf_ext.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ static VALUE cBCryptPbkdfEngine;
*/
static VALUE bc_crypt_pbkdf(VALUE self, VALUE pass, VALUE salt, VALUE keylen, VALUE rounds) {
size_t okeylen = NUM2ULONG(keylen);
if (okeylen == 0 || okeylen > 1024)
return Qnil;
u_int8_t* okey = xmalloc(okeylen);
VALUE out;

Expand All @@ -16,8 +18,10 @@ static VALUE bc_crypt_pbkdf(VALUE self, VALUE pass, VALUE salt, VALUE keylen, VA
(const u_int8_t*)StringValuePtr(salt), RSTRING_LEN(salt),
okey, okeylen,
NUM2ULONG(rounds));
if (ret < 0)
if (ret < 0) {
xfree(okey);
return Qnil;
}
out = rb_str_new((const char*)okey, okeylen);
xfree(okey);
return out;
Expand Down