Skip to content

feat: summarize G1 pause counts and durations - #2

Merged
neonjava merged 2 commits into
feat/day-2-gc-parserfrom
feat/day-3-gc-metrics
Oct 14, 2026
Merged

neonjava merged 2 commits into
feat/day-2-gc-parserfrom
feat/day-3-gc-metrics

Conversation

@neonjava

Copy link
Copy Markdown
Owner

Summary

  • Add constant-size GcSummary and PauseStats aggregation over parsed pause events. Counts are pause summary records, not distinct GC cycles.
  • Keep exact u128 nanosecond totals, optional min/max, and a mean rounded down to one nanosecond. Empty categories expose None for extrema and mean; arithmetic overflow is explicit.
  • Show overall and per-category duration statistics in gc inspect.
  • Validate young/full syntax against real Temurin 17.0.20.1 and 21.0.12.1 G1 output; check in short unchanged excerpts and the reproduction workload.

Verification

  • cargo fmt --all -- --check passed.
  • cargo clippy --workspace --all-targets -- -D warnings passed.
  • cargo test --workspace passed: 20 tests.
  • cargo build --workspace --release passed.
  • CLI help and inspection of both new real fixtures passed.
  • The 10,000-event streaming test still passes.

Limits

  • The JDK 17/21 real excerpts validate young and full summaries. Remark and cleanup examples remain synthetic.
  • Totals describe observed pause summaries; they are not normalized by run time and do not imply a regression.

This PR is stacked on #1 (Day 2 parser). Merge #1 first, then retarget this PR to main.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 55e4436f-d841-43a4-827a-87c21fb57c10

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@neonjava
neonjava merged commit cbc3b32 into feat/day-2-gc-parser Oct 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant