Add a plugin for unpick v3 #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matyrobbrt
added
enhancement
|
XFactHD
reviewed
Jul 18, 2025
Contributor
|
J21 is a bit annoying, sadly. |
shartte
approved these changes
Aug 6, 2025
Contributor
shartte
left a comment
shartte
left a comment
There was a problem hiding this comment.
I did indeed not find Malware in this.
# Conflicts: # cli/src/main/java/net/neoforged/jst/cli/io/FolderFileSink.java
|
🚀 This PR has been released as JavaSourceTransformer version |
Earthcomputer
left a comment
Earthcomputer
left a comment
There was a problem hiding this comment.
Not checked your fancy flow logic, I will assume that works well. In general there are some precedence issues. Even though you shouldn't ever need to add parentheses to an inner unpick expression, because the unpick parser already handles precedence and should construct a tree which when written has precedence that preserves semantics, at the top level you still need to add parentheses based on the context of the surrounding code, and when you are generating new expressions.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a constant uninlining plugin based on the Unpick v3 specification.
Constant uninlining is the practice of reverting the inlining of constant values in decompiled code - an optimisation strategy of the compiler. This plugin will read specification files and uninline constant values in the source according to the specification.
In cases where the specification provides a number format (oct, dex or hex), if it is unable to uninline the value to a specific constant, it will convert it to the specified format.
Java is also bumped to Java 21, making this PR a breaking changes. This is done because the Unpick format library requires Java 21. This should not be a problem for our tooling as NFRT already runs with Java 21.
However, a major bump is still needed.