Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new GitHub Actions workflow intended to build and test stackman on BSD variants using VM-based runners, to validate portability beyond the existing Linux/Windows CI.
Changes:
- Introduces a
buildbsd.ymlworkflow with jobs for FreeBSD, OpenBSD, and NetBSD. - Each BSD job installs
gmakevia the platform package manager and runsgmake abiname,gmake all, andgmake test.
Comments suppressed due to low confidence (2)
.github/workflows/buildbsd.yml:39
steps:is incorrectly indented for the OpenBSD job. The- uses/- nameentries need to be nested understeps:for valid YAML.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6.0.2
- name: build and test
uses: vmactions/openbsd-vm@v1
.github/workflows/buildbsd.yml:61
steps:is incorrectly indented for the NetBSD job. As written, the workflow YAML is invalid and GitHub Actions will reject it.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6.0.2
- name: build and test
uses: vmactions/netbsd-vm@v1
Comment on lines
+13
to
+17
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6.0.2 | ||
| - name: build and test | ||
| uses: vmactions/freebsd-vm@v1 |
Comment on lines
+3
to
+8
| on: | ||
| push: | ||
| branches: [ master, dev ] | ||
|
|
||
| pull_request: | ||
| branches: [ master ] |
tools/abiname.sh created its temporary file with a three-X mktemp template. GNU mktemp accepts that, but BSD mktemp(1) requires at least six Xs and fails with "insufficient number of Xs in template", which made the Makefile abort with "Could not determine platform". Use a six-X template, which is valid for both.
Add a separate workflow that builds the library and runs the full test suite on the three BSDs in a real VM, using the vmactions VM actions on the ubuntu-latest runner. The existing workflow is left untouched. No new ABI, assembly file or platform.h branch is needed: the BSDs on amd64 use the same sysv_amd64 ABI as Linux, and the existing ELF paths in the assembly sources apply unchanged. Consequently the jobs do not upload a library artifact, which would only duplicate the Linux one. GNU make is installed in the prepare step because the Makefile uses GNU make syntax while the BSD base system make is bmake. Closes stackless-dev#15
Owner
Author
|
Fork-internal verification run only: this existed to exercise the new BSD workflow on real GitHub Actions before proposing it. The work is now upstream in stackless-dev#20. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-internal run to exercise the new BSD workflow on real GitHub Actions. Not for upstream.