Skip to content

Row 231: Tristan's Tomb (2238, 2245): Mu Young's start scripts and Jr. Balrog's room - #1048

Merged
neeerp merged 1 commit into
masterfrom
v83/tristan-tomb
Oct 26, 2026
Merged

neeerp merged 1 commit into
masterfrom
v83/tristan-tomb

Conversation

@neeerp

@neeerp neeerp commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Row 231: Who is the Owner of the Mysterious Note? (2238) and To Tristan's Tomb (2245), from report b199's list of quests with no end NPC.

2238

  • Mu Young (1061014, in the Sleepywood dungeon 105100100) starts 2238 through its silent start script q2238s.
  • It ends at Tristan's Spirit (1061015) for the data's 50,000 EXP.

2245: Jr. Balrog's room

  • Mu Young's start script q2245s completes 2245 at once (Effect::FinishQuest) and sends the player into Jr. Balrog's room (910520000) through the new solo EventKind::Tristan.
    • The player goes alone, for ten minutes, and only one player at a time on a channel. Anyone else is told the room is taken and must wait.
    • 2245 has interval 0, so finishing it at once lets it be taken again. Cosmic force-starts it instead, which would leave it stuck as started.
  • The room's unknown Jr. Balrog (9300326) spawns once in each copy. Its fall brings out Tristan's Spirit at (0, 115), as Cosmic's BalrogQuest does. This happens in the field's killed hook, and only once per copy.
  • The room's out00 portal, or the time running out, returns the player to Mu Young.

Golden list

  • supported_quests.txt gains 2238 and 2245. 2245 joins FINISHED_BY_START_SCRIPT.

Text

  • One new key, tristan.room_taken. No licensed script has the line, so it stays a placeholder and is listed as unsourced.

Tests

  • Unit tests: net (the event and the scripts), game-data (classify and the golden list) and runtime. All pass.
  • Harness: the new tristan_tomb test, plus pyramid, pirate_boss and nine_spirit_egg. All pass.
    • The test covers the silent start, the second player being refused, the Spirit appearing after the kill, the end at the Spirit, the way out, the second player's turn ending on time up, and the quest states after relogging.
  • Client ctest: 193/193 in build-dbg.

A review noted that StartEvent runs before the script's quest change is committed. Every StartEvent script already works this way, so this PR doesn't change it.

… start 2238, then take a player on it alone into the unknown Jr. Balrog's room for ten minutes (new solo EventKind::Tristan, one at a time on a channel), completing 2245 so interval 0 lets it repeat; Jr. Balrog's fall brings out Tristan's Spirit, where 2238 ends
@neeerp
neeerp merged commit 25d40e3 into master Oct 26, 2026
1 check passed
@neeerp
neeerp deleted the v83/tristan-tomb branch October 26, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant