Repository navigation
Row 231: Tristan's Tomb (2238, 2245): Mu Young's start scripts and Jr. Balrog's room - #1048
Merged
Merged
Conversation
… start 2238, then take a player on it alone into the unknown Jr. Balrog's room for ten minutes (new solo EventKind::Tristan, one at a time on a channel), completing 2245 so interval 0 lets it repeat; Jr. Balrog's fall brings out Tristan's Spirit, where 2238 ends
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 231: Who is the Owner of the Mysterious Note? (2238) and To Tristan's Tomb (2245), from report b199's list of quests with no end NPC.
2238
q2238s.2245: Jr. Balrog's room
q2245scompletes 2245 at once (Effect::FinishQuest) and sends the player into Jr. Balrog's room (910520000) through the new soloEventKind::Tristan.interval 0, so finishing it at once lets it be taken again. Cosmic force-starts it instead, which would leave it stuck as started.BalrogQuestdoes. This happens in the field'skilledhook, and only once per copy.out00portal, or the time running out, returns the player to Mu Young.Golden list
supported_quests.txtgains 2238 and 2245. 2245 joinsFINISHED_BY_START_SCRIPT.Text
tristan.room_taken. No licensed script has the line, so it stays a placeholder and is listed as unsourced.Tests
tristan_tombtest, pluspyramid,pirate_bossandnine_spirit_egg. All pass.A review noted that
StartEventruns before the script's quest change is committed. EveryStartEventscript already works this way, so this PR doesn't change it.