Repository navigation
Row 231: Reef's Gratitude (2228) completes from Reef's start script with 8 fame - #1047
Merged
Merged
Conversation
…er once Faust is beaten, completing the quest at once with the data's 8 fame (new Effect::GainFame)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 231: Reef's Gratitude (2228). Report b199 lists it among the quests with no end NPC.
The quest
q2228s.Effect::FinishQuest, listed inFINISHED_BY_START_SCRIPT).Act/1 pop) through the newEffect::GainFame. A finish applies noAct/1rewards, so the script gives the fame itself.GainFameshows the fame in the chat log the same way a quest's fame does.gainFame(8).Golden list
supported_quests.txtgains 2228 and nothing else.Text
reef.thanksstays a placeholder and is listed as unsourced.Tests
reef_thanks_the_player_with_eight_fame) and game-data (golden list).reef_gratitudetest, plusquest_fameanddyle_informants. All pass.