Skip to content

Row 231: Reef's Gratitude (2228) completes from Reef's start script with 8 fame - #1047

Merged
neeerp merged 1 commit into
masterfrom
v83/reef-gratitude
Oct 26, 2026
Merged

neeerp merged 1 commit into
masterfrom
v83/reef-gratitude

Conversation

@neeerp

@neeerp neeerp commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Row 231: Reef's Gratitude (2228). Report b199 lists it among the quests with no end NPC.

The quest

  • Once Faust is beaten (2227), Reef (1032108, on 910100001) thanks the player through his start script q2228s.
  • The script completes the quest at once (Effect::FinishQuest, listed in FINISHED_BY_START_SCRIPT).
  • It gives the data's 8 fame (Act/1 pop) through the new Effect::GainFame. A finish applies no Act/1 rewards, so the script gives the fame itself.
  • GainFame shows the fame in the chat log the same way a quest's fame does.
  • Cosmic does the same with gainFame(8).

Golden list

  • supported_quests.txt gains 2228 and nothing else.

Text

  • No licensed script has the line, so reef.thanks stays a placeholder and is listed as unsourced.

Tests

  • Unit tests: net (reef_thanks_the_player_with_eight_fame) and game-data (golden list).
  • Harness: the new reef_gratitude test, plus quest_fame and dyle_informants. All pass.

…er once Faust is beaten, completing the quest at once with the data's 8 fame (new Effect::GainFame)
@neeerp
neeerp merged commit 56b4eaf into master Oct 26, 2026
1 check passed
@neeerp
neeerp deleted the v83/reef-gratitude branch October 26, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant