Skip to content

Row 231: Captain Al's family lessons (2232-2234) end by the Family window's numbers - #1046

Merged
neeerp merged 1 commit into
masterfrom
v83/captain-al-family
Oct 26, 2026
Merged

neeerp merged 1 commit into
masterfrom
v83/captain-al-family

Conversation

@neeerp

@neeerp neeerp commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Row 231: Captain Al's lessons in leading a family (2232–2234). Report b199 lists these among the quests with no end NPC.

The quests

  • Each lesson starts at Captain Al (1002103, in Lith Harbor and Orbis Park) from its Say.img text.
  • Each has an end script (q2232e–q2234e) and no end NPC.
  • classify now accepts a quest with no completion NPC when its Check/1 names an end script. Both the server and HeavenClient already use the start NPC as the end NPC when there is none, so the quests end at Captain Al.

What each script checks

  • The new NpcScript::for_family_quest reads the Family window's numbers through db::family::info, which the runtime loads for these three scripts only.
  • 2232 needs a junior and gives Cosmic's 3,000 EXP.
  • 2233 needs 1,000 Rep earned in total.
  • 2234 needs 2,000 Rep earned in total and less than 500 left to spend.
  • The thresholds come from the quests' own QuestInfo and Say text.
  • The data gives no rewards, and Cosmic has a script for 2232 only.

Golden list

  • supported_quests.txt gains 2232–2234 and nothing else.

Text

  • No licensed script has these lines, so the six family.captain_al.* keys stay as placeholders and are listed as unsourced.

Tests

  • Unit tests: net (each lesson's threshold, done and not yet) and game-data (classify and the golden list).
  • Harness: the new captain_al_family test plus pet_evolution, maker_quests, follow_the_lead and nine_spirit_egg. All pass.
    • The test seats a junior with the new join_family helper and sets Rep with set_family_reputations.
    • It checks each lesson before and after its numbers are met, including 2234 with exactly 500 Rep left.
  • Client ctest: 193/193 in build-dbg.

Also moves the doc comment for Dyle's informants, which the last slice left above the wrong constant, back onto informant.

…scripts at him, by the Family window's numbers: a junior taken (3,000 EXP), 1,000 Rep earned, then 2,000 earned with under 500 left; a Check/1 end script counts as a way to complete
@neeerp
neeerp merged commit f184732 into master Oct 26, 2026
1 check passed
@neeerp
neeerp deleted the v83/captain-al-family branch October 26, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant