Repository navigation
Row 231: Captain Al's family lessons (2232-2234) end by the Family window's numbers - #1046
Merged
Merged
Conversation
…scripts at him, by the Family window's numbers: a junior taken (3,000 EXP), 1,000 Rep earned, then 2,000 earned with under 500 left; a Check/1 end script counts as a way to complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 231: Captain Al's lessons in leading a family (2232–2234). Report b199 lists these among the quests with no end NPC.
The quests
Say.imgtext.q2232e–q2234e) and no end NPC.classifynow accepts a quest with no completion NPC when itsCheck/1names an end script. Both the server and HeavenClient already use the start NPC as the end NPC when there is none, so the quests end at Captain Al.What each script checks
NpcScript::for_family_questreads the Family window's numbers throughdb::family::info, which the runtime loads for these three scripts only.QuestInfoandSaytext.Golden list
supported_quests.txtgains 2232–2234 and nothing else.Text
family.captain_al.*keys stay as placeholders and are listed as unsourced.Tests
captain_al_familytest pluspet_evolution,maker_quests,follow_the_leadandnine_spirit_egg. All pass.join_familyhelper and sets Rep withset_family_reputations.Also moves the doc comment for Dyle's informants, which the last slice left above the wrong constant, back onto
informant.