Skip to content

Feature/passing server fields for lists#7

Merged
mosquito merged 11 commits into
masterfrom
feature/passing-server-fields-for-lists
May 19, 2026
Merged

Feature/passing server fields for lists#7
mosquito merged 11 commits into
masterfrom
feature/passing-server-fields-for-lists

Conversation

@mosquito
Copy link
Copy Markdown
Collaborator

This pull request refactors and streamlines several CLI commands in the contree_cli tool, focusing on deduplication, improved pagination, and enhanced error handling. The most significant changes are the removal of redundant command implementations, the centralization of operation management logic, and the adoption of a generic paginated fetcher for listing commands. These updates improve maintainability, consistency, and user experience.

Command refactoring and deduplication:

  • Removed the standalone kill and ps command implementations, replacing them with aliases to subcommands in operation for unified operation management (contree_cli/arguments.py, contree_cli/cli/kill.py, contree_cli/cli/operation.py). [1] [2] [3] [4] [5] [6] [7]

Pagination and performance improvements:

  • Replaced manual paging logic in images and file ls commands with the new PaginatedFetcher class, supporting concurrency and better handling of result limits (contree_cli/cli/images.py, contree_cli/cli/file.py). [1] [2] [3] [4] [5]

Error handling and robustness:

  • Improved error handling in the main entrypoint to catch and log network errors (including HTTP exceptions), providing clearer feedback to users (contree_cli/__main__.py). [1] [2]

Formatter and output consistency:

  • Updated output formatting to consistently use dictionary unpacking, and configured formatters to display relevant tail columns or error types in ls, images import, and related commands (contree_cli/cli/ls.py, contree_cli/cli/images.py). [1] [2] [3] [4]

Code cleanup:

  • Removed unused imports and improved import organization across several modules for clarity and maintainability (contree_cli/cli/file.py, contree_cli/cli/ls.py). [1] [2]

Let me know if you'd like a walkthrough of any of the new logic or help updating documentation/tests!

@mosquito mosquito requested a review from insomnes May 19, 2026 10:26
Comment thread contree_cli/cli/operation.py
Comment thread contree_cli/cli/file.py Outdated
@mosquito mosquito merged commit c29e5ce into master May 19, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants