Skip to content

CLEANUP: Unify OperationCallback patterns#1079

Merged
jhpark816 merged 1 commit intonaver:developfrom
f1v3-dev:refactor/v2-callback
Apr 21, 2026
Merged

CLEANUP: Unify OperationCallback patterns#1079
jhpark816 merged 1 commit intonaver:developfrom
f1v3-dev:refactor/v2-callback

Conversation

@f1v3-dev
Copy link
Copy Markdown
Collaborator

🔗 Related Issue

⌨️ What I did

  • AsyncArcusCommands 에서 사용되는 OperationCallback 패턴을 통일합니다.
    • receivedStatus 메서드는 모두 switch-case 문으로 교체
    • gotData 메서드에서 CachedData를 로컬 변수로 먼저 선언

@f1v3-dev f1v3-dev requested a review from oliviarla April 20, 2026 05:17
@f1v3-dev f1v3-dev self-assigned this Apr 20, 2026
Copy link
Copy Markdown
Collaborator

@oliviarla oliviarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 주석에 일부 마침표가 없는게 있습니다. 통일하는 김에 같이 수정해주세요.
  • BTreeElement, BTreePositionElement 생성하는 방식이 바뀌었는데, 줄바꿈을 최소화하게 수정해주세요.

@f1v3-dev f1v3-dev force-pushed the refactor/v2-callback branch from f1a6526 to 8c95601 Compare April 20, 2026 09:17
@f1v3-dev
Copy link
Copy Markdown
Collaborator Author

@oliviarla
반영했습니다.

@f1v3-dev f1v3-dev requested a review from oliviarla April 20, 2026 09:17
Comment thread src/main/java/net/spy/memcached/v2/AsyncArcusCommands.java Outdated
@f1v3-dev f1v3-dev force-pushed the refactor/v2-callback branch from 8c95601 to 045594c Compare April 21, 2026 01:03
@f1v3-dev f1v3-dev requested a review from oliviarla April 21, 2026 01:08
@oliviarla oliviarla requested a review from jhpark816 April 21, 2026 01:19
@jhpark816 jhpark816 merged commit 1af24de into naver:develop Apr 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants