fix(ios): Layout children when reusing cell#40
Open
jcassidyav wants to merge 1 commit intonativescript-community:masterfrom
Open
fix(ios): Layout children when reusing cell#40jcassidyav wants to merge 1 commit intonativescript-community:masterfrom
jcassidyav wants to merge 1 commit intonativescript-community:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have for example a Label that on slide 4 becomes two lines where as on slide 1-3 it is one line, when slide 4 is shown it will be truncated because the the view has not been re-layed out for the new data.
If on line:
ui-pager/src/ui-pager/index.ios.ts
Line 1149 in 443ac1b
The check for iosOverflowSafeAreaEnabled is removed, then the
View.layoutChildis called and all appears to be well.