Skip to content

feat: add TText renderer to override all text nodes, including anonymous text #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keerbee-dev wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

feat: add TText renderer to override all text nodes, including anonymous text #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/render/src/render/RenderRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,18 @@ export default class RenderRegistry {
}

getRendererConfigForTNode<T extends TNode>(tnode: T): RendererConfig<T> {
let custom = this.getCustomRendererForTNode(tnode);

// Allow overriding all text nodes via TText
if (!custom && tnode.type === 'text') {
const textRenderer = this.customRenderers['TText'];

@jsamr jsamr Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree with Paweł that it should not be treated as a custom renderer, which are defined for HTML tags, not transient nodes. It's actually a lower level brick that would replace any TText rendering.

if (textRenderer) {
custom = textRenderer as any;

@jsamr jsamr Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely won't allow an any type assertion! That's a well established source of bugs, and it defies the purpose of using TypeScript.

}
}

return {
Custom: this.getCustomRendererForTNode(tnode),
Custom: custom,
Default: this.getDefaultRendererForTNode(tnode)
};
}
Expand Down