Update warning regarding expiration settings#264
Open
ibrahima wants to merge 1 commit intonateware:masterfrom
Open
Update warning regarding expiration settings#264ibrahima wants to merge 1 commit intonateware:masterfrom
ibrahima wants to merge 1 commit intonateware:masterfrom
Conversation
Based on nateware#213 and the comments on nateware@4854553, the current README incorrectly describes an issue with the `expiration` setting when it is actually meant to be describing an issue with the `expireat` setting. This updates the documentation to correctly describe the issue.
Contributor
|
The way the documentation is worded, it almost seems like it should have a "bad example" and a "good example". So the wording is warning you about something, that isn't shown... since the example is already using lambda. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #213 and the comments on 4854553, the current README incorrectly describes an issue with the
expirationsetting when it is actually meant to be describing an issue with theexpireatsetting. This updates the documentation to correctly describe the issue.