Drop single-process and multi-process deployment modes; keep standalone only#298
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
ppenna
July 10, 2026 15:43
View session
There was a problem hiding this comment.
Pull request overview
This PR removes support for Nanvix single-process and multi-process deployment modes across the project, leaving standalone as the only supported mode. It simplifies the build/test paths accordingly and updates documentation and CI configuration to reflect the new constraint.
Changes:
- Restricts the Nanvix build/CI matrices to
["standalone"]only. - Simplifies test execution by removing non-standalone branches and temp-file plumbing.
- Updates Nanvix documentation examples and tables to be standalone-only.
Show a summary per file
| File | Description |
|---|---|
Makefile.nanvix |
Removes non-standalone functional-test path and deletes the now-orphaned _sqlite_test.sql handling. |
.nanvix/z.py |
Collapses testing logic to the standalone functional test implementation and updates Windows test docs/flow accordingly. |
.nanvix/nanvix.toml |
Reduces the build matrix modes list to ["standalone"]. |
.nanvix/NANVIX.md |
Updates examples and tables to document standalone-only support (but CI platform coverage needs correction). |
.github/workflows/nanvix-ci.yml |
Updates workflow inputs so process-modes is ["standalone"]. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 4
- Review effort level: Low
Comment on lines
327
to
+331
| if IS_WINDOWS: | ||
| self._run_tests_windows() | ||
| return | ||
|
|
||
| if self.config.deployment_mode == "standalone": | ||
| allowed = {"test", "test-functional"} | ||
| unknown = [t for t in self.targets if t not in allowed] | ||
| if unknown: | ||
| log.fatal( | ||
| f"Unsupported test target(s) in standalone mode: {unknown}. " | ||
| f"Allowed: {sorted(allowed)}.", | ||
| ) | ||
| self._run_functional_standalone() | ||
| else: | ||
| targets = self.targets or ["test"] | ||
| run(*self._make_args(*targets), cwd=repo_root()) | ||
| allowed = {"test", "test-functional"} |
| ### Build Matrix | ||
|
|
||
| The CI runs on all platform × process-mode × memory combinations: | ||
| The CI runs on all platform × memory combinations: |
Comment on lines
261
to
264
| | Platform | Process Mode | Memory | OS | | ||
| |----------|--------------|--------|----| | ||
| | hyperlight | standalone | 128mb, 256mb | Linux + Windows | | ||
| | hyperlight | single-process | 128mb, 256mb | Linux | | ||
| | hyperlight | multi-process | 128mb, 256mb | Linux | | ||
| | microvm | standalone | 128mb, 256mb | Linux + Windows | |
| | microvm | single-process | 128mb, 256mb | Linux | | ||
| | microvm | multi-process | 128mb, 256mb | Linux | | ||
|
|
||
| All Linux configurations run functional tests in parallel with `fail-fast: false`, ensuring that all platforms are tested even if one fails. Windows standalone tests use `nanvixd.exe` to run `sqlite3.elf` with functional SQL queries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes support for the
single-processandmulti-processNanvix deployment modes across the build matrix, tooling, and docs, leavingstandaloneas the only supported mode.Build matrix
.nanvix/nanvix.toml:modesreduced to["standalone"]..github/workflows/nanvix-ci.yml:process-modesset to["standalone"]in theciandci-scheduledjobs.Build/test tooling
.nanvix/z.py: dropped the non-standalone branch intest()and the non-standalone skip guard in_run_tests_windows(); docstrings/messages updated. ThePROCESS_MODE/deployment_modeplumbing is retained (now alwaysstandalone).Makefile.nanvix:test-functionalnow unconditionally delegates to the standalone path via./z.sh; removed the orphaned_sqlite_test.sqltemp-file handling (also fromclean), which only fed the deleted non-standalone branch.Docs
.nanvix/NANVIX.md: platform/build-matrix tables, artifact + zlib examples, and notes updated to reflect standalone-only support.Out of scope:
multi-process/standalonereferences in upstream SQLite sources (ext/,test/,tool/,ext/wasm/) refer to SQLite's own DB-locking model and WASM build artifacts, and are left untouched.