-
-
Notifications
You must be signed in to change notification settings - Fork 21
Wifi DeviceName has been added #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@zandiarash please use the proper PR template. Thank you. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ellerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good start. Please use the PR template and see my remark about testing the length. Should be done on the native side as well.
Thank you for the guidance. |
Description
I have an ESP32-32D N4 chip
When it connects to the hotspot as a client the device (default) name is nanodevice_31708
I want to change that but I did not found any way to do so (I read the documentation and samples).
I decided to implement that feature as Arduino has.
I’ve changed these projects
Motivation and Context
Now we can set the device name before it connects to any hotspot, router, access point and etc.
Please read these :
nanoframework/nf-interpreter#3243
nanoframework/Samples#446
How Has This Been Tested?
I should mention that I am not familiar with C++ and after I changed nf-interpreter project I flashed my chip like this
nanoff --platform esp32 --target ESP32_REV3 --serialport COM6 --update --clrfile "D:\Sources Electronic\Nanoframework - Copy\nf-interpreter\build\nanoCLR.bin"Screenshots
Before :


After :
Types of changes
Checklist: