Skip to content

Conversation

@zandiarash
Copy link

@zandiarash zandiarash commented Nov 30, 2025

Description

I have an ESP32-32D N4 chip
When it connects to the hotspot as a client the device (default) name is nanodevice_31708
I want to change that but I did not found any way to do so (I read the documentation and samples).
I decided to implement that feature as Arduino has.
I’ve changed these projects

  • NanoSamples
  • nf-interpreter
  • System.Device.Wifi

Motivation and Context

Now we can set the device name before it connects to any hotspot, router, access point and etc.
Please read these :
nanoframework/nf-interpreter#3243
nanoframework/Samples#446

How Has This Been Tested?

I should mention that I am not familiar with C++ and after I changed nf-interpreter project I flashed my chip like this

nanoff --platform esp32 --target ESP32_REV3 --serialport COM6 --update  --clrfile "D:\Sources Electronic\Nanoframework - Copy\nf-interpreter\build\nanoCLR.bin"

Screenshots

Before :
x
After :
x

Types of changes

  • Improvement (non-breaking change that improves a sample)
  • Bug fix (fixes an issue with a current sample)
  • New Sample (adds a new sample)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Documentation/comment (fixes and improvements documentation related)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coderabbitai
Copy link

coderabbitai bot commented Nov 30, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • System.Device.Wifi/WifiAdapter.cs is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Ellerbach
Copy link
Member

@zandiarash please use the proper PR template. Thank you.

@Ellerbach
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good start. Please use the PR template and see my remark about testing the length. Should be done on the native side as well.

@zandiarash
Copy link
Author

@zandiarash please use the proper PR template. Thank you.

Thank you for the guidance.
I’ve updated the pull request to use the proper template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants