Skip to content

Add biome-ignore for JSDoc-only type imports#1646

Draft
Copilot wants to merge 13 commits intomainfrom
copilot/sub-pr-1643
Draft

Add biome-ignore for JSDoc-only type imports#1646
Copilot wants to merge 13 commits intomainfrom
copilot/sub-pr-1643

Conversation

Copy link
Contributor

Copilot AI commented Feb 17, 2026

Lite PR

Tip: Review docs on the ENSNode PR process

Summary

  • Added biome-ignore comment for ErrorResponse import used solely in JSDoc @link references

Why


Testing

  • Code review: no issues
  • CodeQL: no vulnerabilities

Notes for Reviewer (Optional)

Pattern:

// biome-ignore lint/correctness/noUnusedImports: ErrorResponse is used in JSDoc @link
import type { ErrorResponse } from "./response";

/**
 * Schema for {@link ErrorResponse}.
 */
export const ErrorResponseSchema = z.object({...});

This mirrors how types-for-docs are handled elsewhere when linters don't recognize JSDoc references as usage.


Pre-Review Checklist (Blocking)

  • This PR does not introduce significant changes and is low-risk to review quickly.
  • Relevant changesets are included (or are not required)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

tk-o and others added 12 commits February 17, 2026 17:30
The goal of this change is to apply deserialization protocol where data is first transformed into serialized data model in order to be deserialized to business data model.
The goal of this change is to apply deserialization protocol where data is first transformed into serialized data model in order to be deserialized to business data model.
Follows `EnsApiClient` class, but is limited to only two methods: `config()` and `indexingStatus()`.
@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2026

⚠️ No Changeset found

Latest commit: 4c5a696

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
admin.ensnode.io Ready Ready Preview, Comment Feb 17, 2026 8:29pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
ensnode.io Skipped Skipped Feb 17, 2026 8:29pm
ensrainbow.io Skipped Skipped Feb 17, 2026 8:29pm

@vercel vercel bot temporarily deployed to Preview – ensnode.io February 17, 2026 20:26 Inactive
@vercel vercel bot temporarily deployed to Preview – admin.ensnode.io February 17, 2026 20:26 Inactive
@vercel vercel bot temporarily deployed to Preview – ensrainbow.io February 17, 2026 20:26 Inactive
Co-authored-by: tk-o <3687215+tk-o@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – ensnode.io February 17, 2026 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – ensrainbow.io February 17, 2026 20:28 Inactive
Copilot AI changed the title [WIP] WIP address feedback on JSDoc usage for ErrorResponse Add biome-ignore for JSDoc-only type imports Feb 17, 2026
Copilot AI requested a review from tk-o February 17, 2026 20:30
Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

The ErrorResponse type is imported but only used in a JSDoc {@link} comment, triggering biome's noUnusedImports rule without a suppression comment

Fix on Vercel

Base automatically changed from feat/ensindexer-client to main February 17, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments