Rename some structs named UnChecked #22
Merged
Merged
Conversation
In Rust, the term `unchecked` often indicates unsafe code. However, in this case, the struct's `unchecked` means "not yet verified." Renamed the struct to `RawCSRFToken` to avoid confusion. BREAKING CHANGE: The struct name has been changed. Related to ISSUE #21
…e` and constructor method from `from_url` to `new` In Rust, the term `unchecked` often indicates unsafe code. However, in this context, 'unchecked' means "not yet verified," not "unsafe." Renamed the struct to `RawCodeResponse` to avoid confusion. BREAKING CHANGE: The struct name has changed from `UnCheckCodeResponse` to `RawCodeResponse`. Related to ISSUE #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #21
Overview
This PR changes the names of some structs, including,
UnCheckedCSRFTokenandUnCheckedCodeResponse.The purpose is to avoid confusion with "unsafe code", caused by the "unchecked" term.
Changes
UnCheckedCSRFTokentoRawCSRFTokenUnCheckedCodeResponsetoRawCodeResponseRawCodeResponse's construct method name fromfrom_urltonewBreaking Changes
This is a breaking change, as the old struct names are no longer available.