feat(solve): advisory baseline check + progress nudge + DIAG-02 fix#45
Open
feat(solve): advisory baseline check + progress nudge + DIAG-02 fix#45
Conversation
…mpatible verify command
…solve-state.json Incorporate codex-1 quorum improvement: add verification that baseline_advisory is absent from solve-state.json (direct negative check), not just present on jsonObj. This closes the JSON-path concern with explicit path validation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Implement checkBaselinePresence() helper with fail-open JSON parsing - Add --require-baselines flag for CI hard-fail when baselines missing - Emit distinct stderr advisories for missing-file vs zero-baselines cases - Add baseline_advisory field to jsonObj (--json output), not solveState - Augment DIAG-02 layers (R->D, C->R, D->R) with baseline_hint in detail - Update commands/nf/solve.md to document flag and forward in both phases - Update core/workflows/progress.md with baseline check and nudge - Sync installed workflow copy to ~/.claude/nf/workflows/ - Create 6-case test suite with 100% pass rate - Update STATE.md with task completion Resolves DIAG-02 requirement for baseline coverage signaling. Users now see clear advisories when baselines are missing and can opt into hard-fail mode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Includes updated solve-state, gates, model-registry, proximity-index, TLA+/PRISM/Alloy specs, evidence files, and traceability matrix from recent solve and pipeline executions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…reviews Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkBaselinePresence()tobin/nf-solve.cjs— warns whenrequirements.jsonhas no baseline-sourced requirements (advisory stderr +baseline_advisoryJSON field)--require-baselinesflag for CI hard-fail when baselines missingresidual: -1detail objects withbaseline_hintacross 3 sweep functions (sweepRtoD, sweepCtoR, sweepDtoR)core/workflows/progress.md— "run sync-baseline-requirements.cjs"--require-baselinesin both Phase 1 (fresh) and Phase 0.5 (--execute/--resume) pathsbin/nf-solve-baseline-check.test.cjs(100% pass)Motivation
nf:solvesilently skips layers E and K whenrequirements.jsonhas no baselines, producing a deflated residual. Users adopting nForma on existing projects never get prompted to run/nf:sync-baselines. This was identified via quorum consensus (codex-1 + copilot-1, 3 rounds → Option C advisory).Test plan
node --test bin/nf-solve-baseline-check.test.cjs— 6/6 passnode bin/nf-solve.cjs --json --report-only 2>&1 | grep baseline— advisory visiblegrep require-baselines commands/nf/solve.md— flag documentedgrep baseline core/workflows/progress.md— nudge presentdiff core/workflows/progress.md ~/.claude/nf/workflows/progress.md— synced🤖 Generated with Claude Code