Sprint 7 solution in file manager#5
Open
n20va wants to merge 8 commits into
Open
Conversation
irek-valiev
reviewed
Jul 2, 2025
| super.removeSubtaskById(id); | ||
| save(); | ||
| } | ||
|
|
There was a problem hiding this comment.
еще нужно переопределить методы массового удаления сущностей
| task.setId(id); | ||
| return task; | ||
| case "EPIC": | ||
| Epic epic = new Epic(title, description); |
There was a problem hiding this comment.
нужно добавить в эпик статус из файла
| } catch (IOException e) { | ||
| throw new ManagerSaveException("Ошибка при загрузке данных из файла.", e); | ||
| } | ||
|
|
There was a problem hiding this comment.
Сейчас вычитанные из файла Эпики потеряли данные о привязанных к ним подзадачах. Чтобы наполнить внутреннее хранилище Эпиков (subtaskIds) нужно пройтись по всем подзадачам из хранилища subtasks, по значению epicId брать конкретный Эпик из хранилища epics и использовать метод addSubtask()
irek-valiev
reviewed
Jul 3, 2025
| case "EPIC": | ||
| Epic epic = new Epic(title, description); | ||
| epic.setId(id); | ||
| epic.setStatus(Status.NEW); |
There was a problem hiding this comment.
а почему именно NEW? Нужно было передать тот статус, что получили из файла
irek-valiev
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.