Ascii encoding #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
crowbot
commented
Oct 23, 2015
crowbot
commented
- Need tests to demonstrate the new error
crowbot
force-pushed
the
ascii-encoding
branch
from
bd3fd29 to
a74db78
Compare
crowbot
force-pushed
the
ascii-encoding
branch
3 times, most recently
from
aea2d8c to
3fc3975
Compare
crowbot
force-pushed
the
ascii-encoding
branch
from
3fc3975 to
f9f928e
Compare
Rake was failing because PKG_NAME was not defined.
Rescue from Encoding::CompatibilityError when converting Mapi::Mime to a String. In some situations the parts can legitimately be different encodings, but cannot be concatenated given the encoding differences. In this situation, force the encoding to ASCII-8BIT rather than erroring.
garethrees
force-pushed
the
ascii-encoding
branch
from
67abdfb to
fae72e5
Compare
mysociety-pusher
pushed a commit
to mysociety/alaveteli
that referenced
this pull request
Oct 13, 2020
Sometimes we receive messages with outlook attachments that can't be parsed due to an issue in mapi [1]. There's a potential fix [2] but it conflicts [3] with an existing patch we apply [4]. This at least allows users to download the raw attachment, rather than us preventing the entire request from loading because we raise an exception. Part of #5783. [1] aquasync/ruby-msg#15 [2] aquasync/ruby-msg#16 [3] #5783 (comment) [4] mysociety/ruby-msg#3
mysociety-pusher
pushed a commit
to mysociety/alaveteli
that referenced
this pull request
Oct 14, 2020
Sometimes we receive messages with outlook attachments that can't be parsed due to an issue in mapi [1]. There's a potential fix [2] but it conflicts [3] with an existing patch we apply [4]. This at least allows users to download the raw attachment, rather than us preventing the entire request from loading because we raise an exception. It's not easy to include an attachment in the specs to replicate a real error case due to the complexity of removing PII, so I've just stubbed the call to `.open` as we don't care about the specifics in this spec. `script/handle-mail-replies` needs an explicit require as we minimise the load path for that script. Part of #5783. [1] aquasync/ruby-msg#15 [2] aquasync/ruby-msg#16 [3] #5783 (comment) [4] mysociety/ruby-msg#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.