Fix wallpaper-restore.sh: safe ~ expansion, handle spaces, add robustness checks#1462
Open
rajghosh06-dev wants to merge 1 commit intomylinuxforwork:mainfrom
Open
Fix wallpaper-restore.sh: safe ~ expansion, handle spaces, add robustness checks#1462rajghosh06-dev wants to merge 1 commit intomylinuxforwork:mainfrom
rajghosh06-dev wants to merge 1 commit intomylinuxforwork:mainfrom
Conversation
Author
|
Related/Similar Issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wallpaper-restore.sh: safe ~ expansion, handle spaces, add robustness checks (to ~ path)
This PR improves
wallpaper-restore.shby:~expansion with safe handling (only expands leading~).realpath -mto normalize paths.Tested with (following in local machine)
~/Pictures/...paths → expands correctly/home/user/Pictures/...absolute paths → untouched.txt) → rejected, default usedThis prevents corrupted paths and ensures wallpapers are restored reliably across different setups.
Checklist for Reviewing
~expansionrealpath -mBefore vs After
Note to Maintainers:
Thank you for reviewing this contribution. The changes are focused on improving reliability and robustness without altering existing functionality. I appreciate your time and feedback, and I’m happy to make any adjustments if needed.