feat: update Sidepad (focus, right position...)#1353
Open
Esscraye wants to merge 2 commits intomylinuxforwork:mainfrom
Open
feat: update Sidepad (focus, right position...)#1353Esscraye wants to merge 2 commits intomylinuxforwork:mainfrom
Esscraye wants to merge 2 commits intomylinuxforwork:mainfrom
Conversation
…tem and fix when it's on a second screen that has different width
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds configurable positioning for the sidepad feature, allowing users to choose between left or right side placement. It also improves multi-monitor support by using monitor-relative coordinates and implements automatic focus management.
Key changes:
- Added
--positionparameter to configure sidepad placement (left/right) - Implemented focus saving/restoration when hiding/showing the sidepad
- Fixed multi-monitor positioning by using monitor-specific X/Y coordinates
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| dotfiles/.config/sidepad/sidepad | Core script updated with position-aware calculations, monitor-relative coordinates, and focus management |
| dotfiles/.config/ml4w/settings/sidepad-position | New configuration file storing default position ("left") |
| dotfiles/.config/ml4w/scripts/sidepad.sh | Wrapper script updated to load and pass position configuration to the core script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
Owner
|
Thanks for this PR. The launch of 2.9.9.5 is planned already for this weekend. I will test it for 2.9.9.6 |
Contributor
Author
|
Yes sure, you tell me if you want me to modify something :) |
|
Was this ever picked up? |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the ability to configure the Sidepad position (Left or Right), improves multi-monitor support, and enhances focus management for a smoother workflow.
Changes
Context
How Has This Been Tested?
(Cochez la case correspondant à votre distribution)
Checklist
Please ensure your pull request meets the following requirements:
Screenshots
Related Issues
Fixes #1261
Additional Notes
Key Features:
left).--move-leftand--move-rightarguments. If the sidepad is on the right, the logic is inverted so that moving towards the edge always hides it, and moving towards the center opens it./tmp/sidepad-prev-focuswhen opening, and restores focus to that window when closing.x,y,width, andheightof the monitor where the sidepad is located, fixing issues on mixed-resolution setups.