feat!: restore PathRequestLoggingFilter #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meotch
requested review from
RyanJones08,
gerfboy,
mattnichols,
stevecl5 and
tessstoddard
as code owners
Any service implementing this change needs to remove their own logback-spring.xml or add the appenders that will be added to java-mdx-web/src/main/resources/logback-spring.xml to their own instance
meotch
force-pushed
the
mitch/restore_request_logging_filter
branch
from
c9839f3 to
a8c85d1
Compare
meotch
changed the title
tessstoddard
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Turns PathRequestLoggingFilter back on.
Any service implementing this change needs to remove their own logback-spring.xml or add the appenders that will be added to java-mdx-web/src/main/resources/logback-spring.xml to their own instance (
wedgeandpath-connector-hancock-whitneymay need to do this)Fixes # MC-3689
Public API Additions/Changes
None
Downstream Consumer Impact
None, this is internal logging to better troubleshoot incoming/outgoing request/response MDX values
How Has This Been Tested?
Tested locally via SNAPSHOT versions. This will still need to be cautiously tested in deployed test environment past the 12 hour logstash window (6am/6pm) where schemas get dynamically defined for that 12 hour window.
Checklist: