Skip to content

aw/CT-1851 #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ash-wright123 merged 3 commits into from
Dec 2, 2025
Merged

aw/CT-1851 #258

ash-wright123 merged 3 commits into from
Dec 2, 2025

Conversation

@ash-wright123
Copy link
Collaborator

@ash-wright123 ash-wright123 commented Nov 26, 2025

Issue

https://mxcom.atlassian.net/browse/CT-1851

Changes

  • added translation function to powered by footer
  • moved where the delete survey translation is happening

Testing Instructions

  • connect an account using French or Spanish and make sure that during the connecting screen/connected screen the footer is translated
  • connect an account with bad credentials and go to the disconnect screen and make sure that the survey is translated to french and spanish
  • No harm testing.

@ash-wright123 ash-wright123 self-assigned this Nov 26, 2025
@ash-wright123 ash-wright123 added the Needs Review This item needs review label Nov 26, 2025
Jameson13B
Jameson13B previously approved these changes Dec 1, 2025
View reviewed changes
Copy link
Collaborator

@Jameson13B Jameson13B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ash-wright123 ash-wright123 merged commit 9df535b into master Dec 2, 2025
5 checks passed
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

🎉 This PR is included in version 2.15.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jameson13B Jameson13B Jameson13B approved these changes

@codingLogan codingLogan Awaiting requested review from codingLogan codingLogan is a code owner

@mwclemy mwclemy Awaiting requested review from mwclemy mwclemy is a code owner

@wesrisenmay-mx wesrisenmay-mx Awaiting requested review from wesrisenmay-mx wesrisenmay-mx is a code owner

@emilysallstrom emilysallstrom Awaiting requested review from emilysallstrom emilysallstrom is a code owner

Assignees

@ash-wright123 ash-wright123

Labels

Needs Review This item needs review released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ash-wright123 @Jameson13B