-
Notifications
You must be signed in to change notification settings - Fork 12
Handle cache failures #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mogman1
wants to merge
8
commits into
mxenabled:master
Choose a base branch
from
mogman1:handle_redis_failure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3f74bcd
fix tests, address warnings
fa732af
add github workflow to run tests
7b72849
handle cache upstream failure by falling back to RPC call
ff8f75d
handle cache errors in cache class, rewrite fetch method
8cb62c9
explicitly permit cache options
1edb790
refactor dupe code to method, account for string keys in options
c9a2222
include active_remote sooner
ca09ddf
bump to rc version
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # This workflow uses actions that are not certified by GitHub. They are | ||
| # provided by a third-party and are governed by separate terms of service, | ||
| # privacy policy, and support documentation. | ||
| # | ||
| # This workflow will install a prebuilt Ruby version, install dependencies, and | ||
| # run tests and linters. | ||
| name: "active_remote-cached" | ||
| on: | ||
| push: | ||
| branches: [ master ] | ||
| pull_request: | ||
| branches: [ master ] | ||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| ruby-version: [ '3.2', '3.1', '3.0', '2.7', 'jruby-9.4' ] | ||
| gemfile: [ 'rails60', 'rails61', 'rails70' ] | ||
| env: | ||
| RAILS_ENV: test | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
| # Add or replace dependency steps here | ||
| - name: Install Ruby and gems | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| bundler-cache: true | ||
| ruby-version: ${{ matrix.ruby-version }} | ||
| env: | ||
| BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile | ||
| # Add or replace test runners here | ||
| - name: Run tests | ||
| run: bundle exec rake test | ||
| env: | ||
| BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile | ||
| old_tests: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| ruby-version: [ '2.6', 'jruby-9.3' ] | ||
| gemfile: [ 'rails60', 'rails61' ] | ||
| env: | ||
| RAILS_ENV: test | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
| # Add or replace dependency steps here | ||
| - name: Install Ruby and gems | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| bundler-cache: true | ||
| ruby-version: ${{ matrix.ruby-version }} | ||
| env: | ||
| BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile | ||
| # Add or replace test runners here | ||
| - name: Run tests | ||
| run: bundle exec rake test | ||
| env: | ||
| BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| source "https://rubygems.org" | ||
|
|
||
| gem "activesupport", "~> 6.0.0" | ||
| gemspec path: "../" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| PATH | ||
| remote: .. | ||
| specs: | ||
| active_remote-cached (0.2.0) | ||
| active_remote | ||
| activesupport | ||
|
|
||
| GEM | ||
| remote: https://rubygems.org/ | ||
| specs: | ||
| active_remote (6.0.2) | ||
| activemodel (~> 6.0.0) | ||
| activesupport (~> 6.0.0) | ||
| protobuf (>= 3.0) | ||
| activemodel (6.0.6.1) | ||
| activesupport (= 6.0.6.1) | ||
| activesupport (6.0.6.1) | ||
| concurrent-ruby (~> 1.0, >= 1.0.2) | ||
| i18n (>= 0.7, < 2) | ||
| minitest (~> 5.1) | ||
| tzinfo (~> 1.1) | ||
| zeitwerk (~> 2.2, >= 2.2.2) | ||
| coderay (1.1.3) | ||
| concurrent-ruby (1.2.2) | ||
| ffi (1.15.5-java) | ||
| i18n (1.12.0) | ||
| concurrent-ruby (~> 1.0) | ||
| method_source (1.0.0) | ||
| middleware (0.1.0) | ||
| minitest (5.18.0) | ||
| mocha (2.0.2) | ||
| ruby2_keywords (>= 0.0.5) | ||
| protobuf (3.10.7) | ||
| activesupport (>= 3.2) | ||
| middleware | ||
| thor | ||
| thread_safe | ||
| pry (0.14.2) | ||
| coderay (~> 1.1) | ||
| method_source (~> 1.0) | ||
| pry (0.14.2-java) | ||
| coderay (~> 1.1) | ||
| method_source (~> 1.0) | ||
| spoon (~> 0.0) | ||
| rake (13.0.6) | ||
| ruby2_keywords (0.0.5) | ||
| spoon (0.0.6) | ||
| ffi | ||
| thor (1.2.1) | ||
| thread_safe (0.3.6) | ||
| thread_safe (0.3.6-java) | ||
| tzinfo (1.2.11) | ||
| thread_safe (~> 0.1) | ||
| zeitwerk (2.6.7) | ||
|
|
||
| PLATFORMS | ||
| universal-java-1.8 | ||
| universal-java-11 | ||
| x86_64-darwin-22 | ||
| x86_64-linux | ||
|
|
||
| DEPENDENCIES | ||
| active_remote-cached! | ||
| activesupport (~> 6.0.0) | ||
| bundler | ||
| mocha | ||
| pry | ||
| rake | ||
|
|
||
| BUNDLED WITH | ||
| 2.4.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| source "https://rubygems.org" | ||
|
|
||
| gem "activesupport", "~> 6.1.0" | ||
| gemspec path: "../" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| PATH | ||
| remote: .. | ||
| specs: | ||
| active_remote-cached (0.2.0) | ||
| active_remote | ||
| activesupport | ||
|
|
||
| GEM | ||
| remote: https://rubygems.org/ | ||
| specs: | ||
| active_remote (6.1.1) | ||
| activemodel (~> 6.1.0) | ||
| activesupport (~> 6.1.0) | ||
| protobuf (>= 3.0) | ||
| activemodel (6.1.7.3) | ||
| activesupport (= 6.1.7.3) | ||
| activesupport (6.1.7.3) | ||
| concurrent-ruby (~> 1.0, >= 1.0.2) | ||
| i18n (>= 1.6, < 2) | ||
| minitest (>= 5.1) | ||
| tzinfo (~> 2.0) | ||
| zeitwerk (~> 2.3) | ||
| coderay (1.1.3) | ||
| concurrent-ruby (1.2.2) | ||
| ffi (1.15.5-java) | ||
| i18n (1.12.0) | ||
| concurrent-ruby (~> 1.0) | ||
| method_source (1.0.0) | ||
| middleware (0.1.0) | ||
| minitest (5.18.0) | ||
| mocha (2.0.2) | ||
| ruby2_keywords (>= 0.0.5) | ||
| protobuf (3.10.7) | ||
| activesupport (>= 3.2) | ||
| middleware | ||
| thor | ||
| thread_safe | ||
| pry (0.14.2) | ||
| coderay (~> 1.1) | ||
| method_source (~> 1.0) | ||
| pry (0.14.2-java) | ||
| coderay (~> 1.1) | ||
| method_source (~> 1.0) | ||
| spoon (~> 0.0) | ||
| rake (13.0.6) | ||
| ruby2_keywords (0.0.5) | ||
| spoon (0.0.6) | ||
| ffi | ||
| thor (1.2.1) | ||
| thread_safe (0.3.6) | ||
| thread_safe (0.3.6-java) | ||
| tzinfo (2.0.6) | ||
| concurrent-ruby (~> 1.0) | ||
| zeitwerk (2.6.7) | ||
|
|
||
| PLATFORMS | ||
| universal-java-1.8 | ||
| universal-java-11 | ||
| x86_64-darwin-22 | ||
| x86_64-linux | ||
|
|
||
| DEPENDENCIES | ||
| active_remote-cached! | ||
| activesupport (~> 6.1.0) | ||
| bundler | ||
| mocha | ||
| pry | ||
| rake | ||
|
|
||
| BUNDLED WITH | ||
| 2.4.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| source "https://rubygems.org" | ||
|
|
||
| gem "activesupport", "~> 7.0.0" | ||
| gemspec path: "../" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| PATH | ||
| remote: .. | ||
| specs: | ||
| active_remote-cached (0.2.0) | ||
| active_remote | ||
| activesupport | ||
|
|
||
| GEM | ||
| remote: https://rubygems.org/ | ||
| specs: | ||
| active_remote (3.1.2) | ||
| activemodel (>= 4.0) | ||
| activesupport (>= 4.0) | ||
| protobuf (>= 3.0) | ||
| activemodel (7.0.4.3) | ||
| activesupport (= 7.0.4.3) | ||
| activesupport (7.0.4.3) | ||
| concurrent-ruby (~> 1.0, >= 1.0.2) | ||
| i18n (>= 1.6, < 2) | ||
| minitest (>= 5.1) | ||
| tzinfo (~> 2.0) | ||
| coderay (1.1.3) | ||
| concurrent-ruby (1.2.2) | ||
| ffi (1.15.5-java) | ||
| i18n (1.12.0) | ||
| concurrent-ruby (~> 1.0) | ||
| method_source (1.0.0) | ||
| middleware (0.1.0) | ||
| minitest (5.18.0) | ||
| mocha (2.0.2) | ||
| ruby2_keywords (>= 0.0.5) | ||
| protobuf (3.10.7) | ||
| activesupport (>= 3.2) | ||
| middleware | ||
| thor | ||
| thread_safe | ||
| pry (0.14.2) | ||
| coderay (~> 1.1) | ||
| method_source (~> 1.0) | ||
| pry (0.14.2-java) | ||
| coderay (~> 1.1) | ||
| method_source (~> 1.0) | ||
| spoon (~> 0.0) | ||
| rake (13.0.6) | ||
| ruby2_keywords (0.0.5) | ||
| spoon (0.0.6) | ||
| ffi | ||
| thor (1.2.1) | ||
| thread_safe (0.3.6) | ||
| thread_safe (0.3.6-java) | ||
| tzinfo (2.0.6) | ||
| concurrent-ruby (~> 1.0) | ||
|
|
||
| PLATFORMS | ||
| universal-java-1.8 | ||
| universal-java-11 | ||
| x86_64-darwin-22 | ||
| x86_64-linux | ||
|
|
||
| DEPENDENCIES | ||
| active_remote-cached! | ||
| activesupport (~> 7.0.0) | ||
| bundler | ||
| mocha | ||
| pry | ||
| rake | ||
|
|
||
| BUNDLED WITH | ||
| 2.4.12 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.