Add callback for guarded transcations

[mgavrila]

Feature

• exposed setIsSigningUiEnabled for toggling on/off signing UI screens
• added callback for signTransactions before panel close

Contains breaking changes

• No
• Yes

Updated CHANGELOG

• No
• Yes

Testing

• User testing
• Unit tests

[gemini-code-assist]

Summary of Changes

Hello @mgavrila, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the transaction signing process by providing developers with more control and flexibility. It introduces a new callback mechanism that allows for custom processing of signed transactions before they are finalized and the signing interface is dismissed. Additionally, it exposes a new action to programmatically manage the state of the signing UI, improving adaptability for various Dapp integration scenarios.

Highlights

• New Callback for Signed Transactions: Introduced an optional callback in SignTransactionsOptionsType that allows custom logic to be executed on signed transactions before the signing panel closes and before transactions are guarded.
• Signing UI Control: Exposed a new action setIsSigningUiEnabled to programmatically toggle the visibility or enablement of the signing UI screens.
• Transaction Guarding Refactor: Adjusted the application of guardTransactions across different provider strategies, specifically removing it from CrossWindowProviderStrategy and re-introducing it in WalletConnectProviderStrategy, now integrated with the new callback mechanism.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Summary of Changes

Hello @mgavrila, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the transaction signing experience by providing developers with more granular control over the user interface and introducing a flexible callback mechanism. It allows for dynamic management of the signing UI's visibility and the execution of custom logic immediately after transactions are signed, thereby improving the adaptability and integration capabilities for dApp interactions.

Highlights

• UI Control for Transaction Signing: Introduced a new setIsSigningUiEnabled function, allowing programmatic control over the visibility of the transaction signing UI screens.
• Post-Signing Callback: Added an optional callback function to the signTransactions process, which executes after transactions are signed but before the signing panel closes, enabling custom logic to be run at this critical stage.
• Transaction Guarding Refactor: Refactored the application of transaction guarding logic to ensure consistent behavior across different provider strategies, specifically moving its invocation within the WalletConnect provider.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a callback for post-processing signed transactions and exposes a new configuration setter, setIsSigningUiEnabled. The overall direction is good, but there are a few issues to address. I've found a leftover debugging statement and a ts-ignore that should be removed. More importantly, the new callback option isn't consistently passed through all provider strategies, which makes the feature incomplete for several providers. My detailed comments are below.

[gemini-code-assist]

Code Review

This pull request introduces a new callback option for the signTransactions flow, which allows for processing signed transactions before they are sent for guardian approval. It also adds a new setIsSigningUiEnabled action to control the visibility of the signing UI. The implementation of the new features seems correct, but I've identified a critical issue with a method signature mismatch that will prevent the code from working, as well as a leftover debug statement that should be removed. Please see my detailed comments.

[arhtudormorar]

add callback docs in README.md. What can it be used for? Example: verify/validate the signed transactions with a processing function bevore closing the UI and receiving them