Check tokens created within all tokens processing time window - #1637
Open
stefangutica wants to merge 4 commits into
Open
Check tokens created within all tokens processing time window#1637stefangutica wants to merge 4 commits into
stefangutica wants to merge 4 commits into
Conversation
|
k6 load testing comparison.
Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
getAllTokensRaw, run by the cache warmer every 2 minutes, takes tens of seconds: it fetches the token list once at the start and then processes every token. Any token created after that initial fetch is missing from the result until the next refresh.t1, a token is created att2and appended to the cached list by the transaction processor, and warming finishes att3(t1 < t2 < t3), the warmer overwrites the cache with a list that does not contain the new token. The token appears and then disappears until the next refresh.Proposed Changes
fetchAllTokensWithoutDetailsso both passes share it.How to test
npx jest src/test/unit/services/tokens.spec.ts. The new cases check that only tokens created in the meantime are processed in the second pass and that they are included in the result, and that a failing second fetch keeps the already processed tokens.All Tokens invalidationscron is running. The token should still be inGET /tokensafter the warmer finishes, and the logs should showProcessing N tokens created while processing all tokens.GET /tokensreturns the same count and order as before.