Fix voice memory and bitstream leaks, crashes, game loop stall - #5254
Open
Dutchman101 wants to merge 3 commits into
Open
Fix voice memory and bitstream leaks, crashes, game loop stall#5254Dutchman101 wants to merge 3 commits into
Dutchman101 wants to merge 3 commits into
Conversation
Dutchman101
marked this pull request as draft
August 21, 2026 08:04
Dutchman101
marked this pull request as ready for review
August 21, 2026 14:19
FileEX
reviewed
Aug 21, 2026
| { | ||
| // Initialize our speex decoder | ||
| speex_decoder_ctl(m_pSpeexDecoderState, SPEEX_GET_FRAME_SIZE, &m_iSpeexIncomingFrameSampleCount); | ||
| int iQuality = ucQuality; |
Member
There was a problem hiding this comment.
auto quality = static_cast<std::uint32_t>(m_pVoiceRecorder->GetSampleQuality());ucQuality is no longer used, so it can be removed
FileEX
reviewed
Aug 21, 2026
| if (m_pSpeexEncoderState) | ||
| { | ||
| speex_encoder_ctl(m_pSpeexEncoderState, SPEEX_GET_FRAME_SIZE, &m_iSpeexOutgoingFrameSampleCount); | ||
| int iQuality = m_ucQuality; |
Member
There was a problem hiding this comment.
Same here, it's worth adding an explicit cast. Also, the result can't be negative, so it could be an unsigned int
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main benefits: