Fix #5177 different colors for /showcol for clientsided and serverside collisions - #5253
Open
PlatinMTA wants to merge 2 commits into
Open
Fix #5177 different colors for /showcol for clientsided and serverside collisions#5253PlatinMTA wants to merge 2 commits into
/showcol for clientsided and serverside collisions#5253PlatinMTA wants to merge 2 commits into
Conversation
Colshape debug rendering used one fixed color per shape type, so there was no way to tell serverside shapes from clientside ones. Add CClientColShape::GetDebugColor, which keeps the shape type color for serverside shapes and returns a lighter shade of it for clientside ones. Shapes owned by a marker or pickup follow the side of the owning element, since their own element ID is always clientside. Closes multitheftauto#5177
No need to check for marker or pickups they never get rendered in debug mode, smh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CClientColShape::GetDebugColor, which takes the base color of the colshape debug render and makes it lighter if the colshape is owned by the client.
Motivation
Colshape debug rendering used one fixed color per shape type, so there was no way to tell serverside shapes from clientside ones.
Closes #5177
Test plan
Checklist