Fix removed world models reappearing after building pool resize - #5251
Open
PlatinMTA wants to merge 1 commit into
Open
Fix removed world models reappearing after building pool resize#5251PlatinMTA wants to merge 1 commit into
PlatinMTA wants to merge 1 commit into
Conversation
Fixes multitheftauto#4722 When the building pool is resized CGameSA::SetBuildingPoolSize removes the whole game world with a backup, resizes the pool and restores the backup. The issue is that it ends up forgetting about the removed LLODs and adds them back. CBuildingsPoolSA::RestoreBackup and CDummyPoolSA::RestoreBackup now call ``AddDataBuildingAndReapplyRemoval``, removing the LLODs correctly after restoring. Tested in a very heavy gamemode with around 3300 buildings, forcing ``engineSetPoolCapacity("building", 18000)`` (which would trigger the bug) and also tested ``removeGameWorld()`` and ``restoreGameWorld()`` for good measure. All seems good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the building pool is resized CGameSA::SetBuildingPoolSize removes the whole game world with a backup, resizes the pool and restores the backup. The issue is that it ends up forgetting about the removed LLODs and adds them back.
CBuildingsPoolSA::RestoreBackup and CDummyPoolSA::RestoreBackup now call
AddDataBuildingAndReapplyRemoval, removing the LLODs correctly after restoring.Motivation
Fixes #4722
Test plan
Tested in a very heavy gamemode with around 3300 buildings, forcing
engineSetPoolCapacity("building", 18000)(which would trigger the bug) and also testedremoveGameWorld()andrestoreGameWorld()for good measure. All seems good.Checklist