Add #5234: Automatic connection retries - #5236
Open
x6c85 wants to merge 1 commit into
Open
Conversation
Previously only one retry was attempted after 4 seconds, with an 8-second timeout. Now the client retries up to 5 times at 4-second intervals (20s total) and shows the current attempt number in the connection dialog. Errors like bans, invalid passwords, or full servers still abort immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry connecting to a server up to 5 times (every 4 seconds) instead of the previous single retry. The connection dialog now shows the current attempt number (e.g.
Connecting to ... (attempt 2/5)).Motivation
Fixes #5234. When a server is temporarily busy or a UDP packet is dropped, users had to manually press Join again. This automates retries so the client keeps trying for 20 seconds total before giving up. Errors like bans, invalid passwords, or a full server still abort immediately without retrying.
Test plan
Checklist