Fix #5225: Apply ped alpha to the jetpack clump - #5226
Open
x6c85 wants to merge 3 commits into
Open
Conversation
CTaskSimpleJetPack::RenderJetPack draws from its own clump, so setPedAlpha never reached the pack. Copy the ped clump alpha onto the jetpack and skip render/FX/sound when the ped is fully hidden.
Member
|
Tested, it works. Do you think you could also adjust the alpha of the FX effect? ped.alpha = 1 |
FxSystem has no colour alpha, so thruster spawn rate is scaled by ped alpha and thrusters are respawned on alpha changes to drop leftover full-bright particles (e.g. me.alpha = 1).
Contributor
Author
|
Good catch, FX has no colour alpha, so the pack materials were translucent while the flames stayed full-bright. Pushed a follow-up that scales thruster spawn rate by ped alpha and clears leftover particles when alpha changes (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CTaskSimpleJetPack::RenderJetPackdraws the jetpack from its own clump, sosetPedAlpha/me.alphanever reached it. The existing RenderJetPack hook now copies the ped clump alpha onto the jetpack materials, and skips render, thruster FX and engine sound when the ped is fully hidden (alpha 0 or a different interior).Motivation
Fixes #5225. Getting a jetpack and running
crun me.alpha = 0hid the ped but left a floating pack.Test plan
crun me.alpha = 0: ped, jetpack, thrusters and jetpack sound should all disappear.crun me.alpha = 128: ped and jetpack should both be translucent.crun me.alpha = 255: ped and jetpack should be fully visible again, sound restored.Checklist