supervisor: unify per-process lifecycle and bundle per-process state#24
Merged
congwang-mk merged 3 commits intomainfrom Apr 26, 2026
Merged
supervisor: unify per-process lifecycle and bundle per-process state#24congwang-mk merged 3 commits intomainfrom
congwang-mk merged 3 commits intomainfrom
Conversation
Signed-off-by: Cong Wang <cwang@multikernel.io>
Signed-off-by: Cong Wang <cwang@multikernel.io>
Signed-off-by: Cong Wang <cwang@multikernel.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three-step refactor of the supervisor's per-process state, originally motivated by a leak I noticed in commit 25afe7f (Linux arm64 sandbox runtime support):
cow: prune virtual_cwds/dir_cache for exited PIDs— minimal fix for the leak: `prune_reused_pid` only fires when a new process recycles a numeric PID, so without periodic cleanup `CowState::virtual_cwds` and `dir_cache` grow with the number of distinct child PIDs over the supervisor's lifetime. Adds a 30s GC sweep that drops entries whose process is gone.Notable design points
Test plan
🤖 Generated with Claude Code