[ui] fix: send collection intervals as numbers - #11819
Open
cananoo wants to merge 2 commits into
Open
Conversation
added 2 commits
September 1, 2026 18:10
Convert collection source update intervals at the API boundary so numeric form input is serialized as a JSON number. Constrain the form to the backend's minute-based integer contract and cover the request body with a focused Playwright regression test.\n\nAssisted-by: Codex:gpt-5 [eslint] Signed-off-by: pengmin <minpeng@semigraph.com>
Document the collection source endpoints and their minute-based update_interval contract.\n\nAssisted-by: Codex:gpt-5 Signed-off-by: pengmin <minpeng@semigraph.com>
cananoo
force-pushed
the
fix/collection-source-interval-number
branch
from
September 1, 2026 10:10
ba23aa7 to
2c39531
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11815
The collection source form keeps input values as strings, so a numeric update interval was serialized as a JSON string and rejected by the Go API. This change:
Notes for Reviewers
The API behavior and default interval are unchanged. Empty intervals remain omitted so the server continues to apply its existing default.
Signed commits
Validation
npx eslint e2e/collections.spec.js src/utils/api.js src/pages/CollectionDetails.jsx(0 errors; existing warnings only)npm run lint:inline-stylesnpm run buildnpx playwright test e2e/collections.spec.js --project=chromium --list