Skip to content

Unify public pages with the living code-glyph theme - #51

Open
msrivas-7 wants to merge 4 commits into
mainfrom
dev/public-theme-continuity
Open

Unify public pages with the living code-glyph theme#51
msrivas-7 wants to merge 4 commits into
mainfrom
dev/public-theme-continuity

Conversation

@msrivas-7

@msrivas-7 msrivas-7 commented Sep 9, 2026

Copy link
Copy Markdown
Owner

What changes

Public pages now feel like one continuation of the homepage: the same living code-glyph field, near-black palette, aligned navigation and readable content. Login and signup stay centered. Shared design tokens keep future theme changes in one place.

User journeys — before → now

  • Different page backgrounds and load flashes → consistent first paint and a shared public theme, without changing saved workspace preferences.
  • Long-page navigation retained the old scroll position → new destinations begin at their heading; Back and explicit anchors keep their intended behavior.
  • Loading could lose navigation/focus → loading pages retain an escape route and hand focus to the destination.
  • Direct walkthrough links could arrive at the top → delayed content correctly receives the anchor unless the visitor takes control.
  • Malformed shares could look like connection failures → clear unavailable state; genuine connection failures still offer Retry.
  • Long shared-code reveals moved the footer and took too long → stable layout and a five-second typing cap; reduced motion reveals immediately.
  • Phone particle shapes disappeared too quickly → more native scrolling space to form and read each scene. Owner verified and approved on iPhone.

Scope and evidence

  • UX-198–224: all 27 findings locally verified; detailed checklist in docs/PUBLIC_THEME_CONTINUITY.md.
  • Actual Codex in-app browser: connected public/auth/legal/discovery/share/trial journeys; keyboard/focus, cold paint/history, phone/desktop readability, live reduced motion, loading/error and graphics recovery. Screenshots and per-finding evidence retained in the local harness.
  • Saved Light workspace preference survives the public dark theme. Anonymous editor and signed-in workspace remain undecorated.
  • 632 frontend tests; production build/typecheck and unchanged asset budgets.
  • 96 focused Chromium/WebKit checks, retries disabled. Full CI is a separate gate.
  • CI follow-up updates two stale test contracts (old DOM glyphs and loading-heading readiness), without changing product code or relaxing the one-second reduced-motion requirement. The 476-test suite crossed its measured capacity boundary; a full 16/20-shard rebenchmark is required before release.
  • Benchmark parity: both capacity candidates now use the normal duration planner with one frozen inventory/history. All 476 tests remain assigned exactly once; 27 contract tests and pinned actionlint pass. Measured GitHub results are pending. Automatic shard-count selection is a separate follow-up, not included here.
  • Entry metadata and auth function-body comparisons passed; no backend, database, authored-course or API changes. New static 404 remains noindex and must retain HTTP 404 on the deployed host.

Release gates / known limitation

  • Owner approved the current design and iPhone experience. Keep existing no-pause-button behavior and OS Reduce Motion; this is not a claim of WCAG conformance.
  • Require green CI and completed clean Codex review on the final head; reply to and resolve actionable findings.
  • Deployment and exact-production changed/adjacent browser verification remain pending. Local results do not claim production success.
  • Development docs describe the owner's persistent phone gateway; its machine-local service/configuration are not part of this PR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T01:32:30.431160Z 78c7b1f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@msrivas-7

Copy link
Copy Markdown
Owner Author

@codex review Please review the complete PR on the latest head for actionable correctness, accessibility, lifecycle, routing and regression issues. Auth/access behavior and workspace preferences must remain unchanged. Product owner approved the visual direction; the documented motion-conformance limitation is not a conformance claim.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-flower-093ba7e0f-51.eastus2.7.azurestaticapps.net

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 477be0a1a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@msrivas-7

Copy link
Copy Markdown
Owner Author

@codex review Updated only legacy test contracts and audit status in 26e2dec: compare the actual moving canvas/still fallback instead of retired DOM glyphs, and wait for the exact share title before enforcing the unchanged one-second reduced-motion deadline. Product source is unchanged. Please review the latest head. Full CI and the required measured shard-capacity rebenchmark remain release gates.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-flower-093ba7e0f-51.eastus2.7.azurestaticapps.net

@msrivas-7

Copy link
Copy Markdown
Owner Author

@codex review Latest head 78c7b1f also repairs the required capacity benchmark: freeze a single inventory/timing history and use the current duration planner at both 16 and 20 shards. No product code, default shard count, test coverage, or quality threshold changed. 27 contract tests, full current inventory planning, and pinned actionlint pass. Please review the final head; measured benchmark results remain pending.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-flower-093ba7e0f-51.eastus2.7.azurestaticapps.net

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 78c7b1f32f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant