Gsoc2019 pmph dist martinskrodzki #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing loop into previous loop.
…second triangle mesh.
…d solution is: Hausdorff distance will be attained at Point (0,0,1) and should be sqrt(3).
sloriot
reviewed
Jul 1, 2019
| Point_3 v1 = query.vertex(1); | ||
| Point_3 v2 = query.vertex(2); | ||
| // Compute the barycenter of the triangle | ||
| Point_3 tri_center = Point_3( 0.3*(v0.x()+v1.x()+v2.x()), 0.3*(v0.y()+v1.y()+v2.y()), 0.3*(v0.z()+v1.z()+v2.z()) ); |
Owner
Author
There was a problem hiding this comment.
Will use CGAL::barycenter for this.
|
|
||
| // Determine whether child nodes will still contribute to a larger | ||
| // Hausdorff distance and thus have to be entered | ||
| bool do_intersect(const Query& query, const Node& node) const |
Collaborator
There was a problem hiding this comment.
query is not used, this is surprising
| // Compute the distance of the center to the closest point in tm2 | ||
| double dist = approximate_sqrt(squared_distance(center, closest)); | ||
| // Compute the radius of the circumsphere of the bounding boxes | ||
| double radius = approximate_sqrt(squared_distance( |
Collaborator
There was a problem hiding this comment.
did you investigate using the distance to bbox?
…s where a triangle is never projected onto a single triangle in the other mesh.
…make print outs optional via a debug parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use the following template to help us managing pull requests.
Summary of Changes
Pull request for review of GSoC code for the first evaluation period. A first implementation of the bounded Hausdorff algorithm was done, it has quite some opportunities to enhance its speed, but it works.
Release Management