Add typing in Python code#660
Open
peasoft wants to merge 4 commits intomsgpack:mainfrom
Open
Conversation
| __slots__ = ["seconds", "nanoseconds"] | ||
|
|
||
| def __init__(self, seconds, nanoseconds=0): | ||
| def __init__(self, seconds: int, nanoseconds=0): |
Contributor
There was a problem hiding this comment.
Shouldn't this also have typing for nanoseconds? Or are you deliberately not adding type annotations where the type can be deduced maybe?
I'm asking because I believe e.g. mypy wouldn't like this (partial type hinting in function definitions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Python 3.10-style typing for msgpack-python.
Compared to sbdchd/msgpack-types and #404, this PR added typing for all Python codes.
Closes #448