Repository navigation
Quirk: finally overriding return and swallowing exceptions - #109
Merged
Merged
Conversation
Test Results292 tests +5 289 ✅ +5 6s ⏱️ -1s Results for commit 6f7e53c. ± Comparison against base commit ea35b4f. This pull request skips 1 and un-skips 1 tests. |
|
@mperor ⏰ This daily topic is still waiting for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What you'll learn
returninsidefinallysilently replaces the value already queued bytry'sreturnreturninsidefinallydiscards any exception in flight, so the caller never sees ittry's return expression is evaluated and captured beforefinallyruns, so reassigning a primitive local afterwards has no effect on the returned valuefinallyis visible to the callerclose()is attached as a suppressed exception instead of replacing itWhy it matters
return/break/continueinfinallyis a classic footgun — it can mask bugs by silently discarding exceptions, and relying on it is almost always a mistake. Knowing how value capture works also clarifies why mutating an object differs from reassigning a primitive during cleanup.Read more
JLS §14.20.2 — Execution of try-finally
Quiz
What happens when
test()is called?Answer
It returns `"finally"` normally — no exception is thrown. The `return` in `finally` always wins: it discards the exception propagating out of `try` before it reaches the caller.Closes #96