Repository navigation
Conversation
Remove the overlapping 08D4 range, which matched U+08E2, and add the combining marks at U+0897-089F and U+08CA-08D3. Signed-off-by: anqorithm <61029571+anqorithm@users.noreply.github.com>
Contributor
Author
|
Fixed the fork-only review failure in 55cc668. The credentialed Claude review job now runs only for same-repository branches; ordinary CI continues to test fork PRs. Upstream CI passes on Python 3.10–3.15, and the Claude job correctly skips for this fork. Locally: 20 tests passed, 3 optional-dependency skips, and actionlint passed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #63
The issue is right about both lines. Checked against Unicode 16:
ࣔ-࣡andࣔ-࣭overlap, and together they match U+08E2 ARABIC DISPUTED END OF AYAH. That's a format character (Cf), not a mark, so it was deleted along with the harakat.ب+ U+08D0 +بgave two isolated behs instead of initial and final.The extended ranges are now
-࢟,࣊-࣡andࣣ-ࣿ. Every ArabicMncharacter in U+0600–08FF is now matched.Behaviour change to check: U+08E2 is no longer treated as a haraka, so
delete_harakatkeeps it. That seems right for a Quranic sign, but it's your call. I left U+06E5 and U+06E6 (small waw and small yeh,Lm) as they were.Testing: added
test_006_harakat_ranges.py, which checks joining across the new marks and that U+08E2 is kept. Both tests fail without this change, and the whole suite passes. I tested on Python 3.11, which ships Unicode 14, so U+0897 (added in 15) is covered by the regex but wasn't checked against a Unicode 15 database.CI follow-up: restrict the credentialed Claude review job to branches in this repository. Fork PRs cannot receive its OAuth secret or write OIDC token; the ordinary test workflow remains enabled for forks. Local validation: 20 passed, 3 optional-dependency skips, plus actionlint. Upstream CI now passes on Python 3.10–3.15; the credentialed review job is skipped for this fork.