Repository navigation
Add Kurdish letter lam with small v to the Kurdish table - #104
Merged
Merged
Conversation
U+06B5 was missing, so it stayed unshaped in Kurdish text. Signed-off-by: anqorithm <61029571+anqorithm@users.noreply.github.com>
Owner
|
@claude take a look at this, review, check tests, confirm everything is in order. |
|
Claude finished @mpcabd's task in 24s —— View job Review of PR #104The change looks correct from reading it. I could not run the tests, because my environment denied approval for
Suggestions (minor)
Open question (needs the maintainer)
Verdict: The code and tests look right. Nothing is blocking apart from the font verification above. I did not make any changes. |
- Write the private-use code points as escapes so the expected values are visible in diffs and editors. - Compare the whole reshaped output with assertEqual instead of assertIn, so a wrongly shaped neighbour or extra output also fails. - Add real Kurdish words that put the letter after a non-joining letter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
ڵ(U+06B5) was missing fromLETTERS_KURDISH, so Kurdish text left it unshaped. This adds it with the mapping from the issue, which the reporter said worked for them.Please check the mapping: Unicode has no presentation forms for this letter, so the initial, medial and final forms use private-use code points (
U+E008,U+E009,U+E007), like the other Kurdish-specific letters in the table. These depend on the font, and I couldn't check them against Sarchia or another Kurdish font, so I can't confirm the right glyphs appear on screen.Testing: added a test covering all four forms, which fails without this change. All tests in
arabic_reshaper/testspass. Only the Kurdish table changed.