Bug 2006821: Add Job states using TextChoices #9129
+64
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the job model to use a fixed set of TextChoices similar to an Enum. This ensures that the operations such as comparisons of Job states involve fixed string constants and are not susceptible to any typos.
Fix formatting
Added the migration
camd
approved these changes
Dec 19, 2025
Collaborator
camd
left a comment
camd
left a comment
There was a problem hiding this comment.
I didn't try running with this, but it looks good to me! Great idea to do this.
Contributor
Author
|
@Archaeopteryx Please can you review this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Introduced
This change updates the job model to use a fixed set of TextChoices similar to an Enum. This ensures that the operations such as comparisons of Job states involve fixed string constants and are not susceptible to any typos.
Testing