Bug-1452249: Removed redundant lines in test #9060
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camd
reviewed
Dec 8, 2025
Collaborator
camd
left a comment
camd
left a comment
There was a problem hiding this comment.
This change makes sense. But looks like there are some test failures. I can review once those are fixed. Thanks!!
Removing the lines that check for job_log status at the end of test `test_ingest_twice_log_parsing_status_changed` as no asserts are being called there and the test has already achieved it's objective before that line.
Contributor
Author
|
Update: Moved PR to draft and rebased changes onto master. Beginning work on fixing failing tests now. |
Contributor
Author
|
@camd Moving this back to review. I did not have to correct any tests. All I did was rebase my changes onto master and pushed the changes to my branch. The pipeline ran the tests and all tests passed. Please can you review them again. |
Contributor
Author
|
@camd @Archaeopteryx Please can you review this now that the tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Bug-1452249
As part of this we remove the lines that check for job_log status at the end of test
test_ingest_twice_log_parsing_status_changed.No asserts are being called there and as per @camd , the test has already achieved it's objective before that line.