Skip to content

Remove unnecessary rect modification in the CanvasGraphics.prototype.beginAnnotation method - #21729

Open
Snuffleupagus wants to merge 1 commit into
mozilla:masterfrom
Snuffleupagus:beginAnnotation-rm-rect-modification
Open

Remove unnecessary rect modification in the CanvasGraphics.prototype.beginAnnotation method#21729
Snuffleupagus wants to merge 1 commit into
mozilla:masterfrom
Snuffleupagus:beginAnnotation-rm-rect-modification

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

This code was added in PR #14247, however it appears that it was unnecessary even back then.
Note how the rect variable isn't actually being used after it's been copied/updated inside of the hasOwnCanvas && this.annotationCanvasMap-branch, and it's also not used at the end of the beginAnnotation method.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8aa02369251811d/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/aa5059b23c26ab1/output.txt

@codecov-commenter

codecov-commenter commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.08%. Comparing base (c2bbde1) to head (7e764c0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21729      +/-   ##
==========================================
- Coverage   90.09%   90.08%   -0.01%     
==========================================
  Files         264      264              
  Lines       67194    67230      +36     
==========================================
+ Hits        60538    60565      +27     
- Misses       6656     6665       +9     
Flag Coverage Δ
browsertest 66.35% <ø> (-0.04%) ⬇️
fonttest 8.99% <ø> (ø)
integrationtest 69.28% <ø> (+<0.01%) ⬆️
unittest 58.24% <ø> (-0.03%) ⬇️
unittestcli 56.60% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/aa5059b23c26ab1/output.txt

Total script time: 16.52 mins

  • Regression tests: Passed

@Snuffleupagus
Snuffleupagus marked this pull request as ready for review August 7, 2026 11:52
@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/8aa02369251811d/output.txt

Total script time: 23.27 mins

  • Regression tests: Passed

…pe.beginAnnotation` method

This code was added in PR 14247, however it appears that it was unnecessary even back then.
Note how the `rect` variable isn't actually being used after it's been copied/updated inside of the `hasOwnCanvas && this.annotationCanvasMap`-branch, and it's also not used at the end of the `beginAnnotation` method.
@Snuffleupagus
Snuffleupagus force-pushed the beginAnnotation-rm-rect-modification branch from f98dee5 to 7e764c0 Compare August 9, 2026 20:09
@Snuffleupagus
Snuffleupagus deployed to code-coverage August 9, 2026 20:09 — with GitHub Actions Active
@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

Rebasing to master, no code changes made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants