Remove unnecessary rect modification in the CanvasGraphics.prototype.beginAnnotation method - #21729
Conversation
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8aa02369251811d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/aa5059b23c26ab1/output.txt |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21729 +/- ##
==========================================
- Coverage 90.09% 90.08% -0.01%
==========================================
Files 264 264
Lines 67194 67230 +36
==========================================
+ Hits 60538 60565 +27
- Misses 6656 6665 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/aa5059b23c26ab1/output.txt Total script time: 16.52 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/8aa02369251811d/output.txt Total script time: 23.27 mins
|
…pe.beginAnnotation` method This code was added in PR 14247, however it appears that it was unnecessary even back then. Note how the `rect` variable isn't actually being used after it's been copied/updated inside of the `hasOwnCanvas && this.annotationCanvasMap`-branch, and it's also not used at the end of the `beginAnnotation` method.
f98dee5 to
7e764c0
Compare
|
Rebasing to |
This code was added in PR #14247, however it appears that it was unnecessary even back then.
Note how the
rectvariable isn't actually being used after it's been copied/updated inside of thehasOwnCanvas && this.annotationCanvasMap-branch, and it's also not used at the end of thebeginAnnotationmethod.