Move editToolbar and fix overlapping annotations with it - #21723
Draft
LoukasPap wants to merge 1 commit into
Draft
Move editToolbar and fix overlapping annotations with it#21723LoukasPap wants to merge 1 commit into
LoukasPap wants to merge 1 commit into
Conversation
LoukasPap
changed the title
LoukasPap
marked this pull request as draft
August 6, 2026 20:49
Author
|
This is currently a draft because I haven't yet added the integration tests. I pushed anyway to make sure we agree with the solution and then move on. |
LoukasPap
force-pushed
the
fix/link-overlaps-floating-toolbar
branch
from
August 6, 2026 20:55
8b69992 to
7c9c34c
Compare
LoukasPap
force-pushed
the
fix/link-overlaps-floating-toolbar
branch
from
August 6, 2026 20:58
7c9c34c to
c48cbd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21643
I moved the editToolbar up to page level and added
isolation: isolateto.annotationLayer,.annotationEditorLayerand.editor toolbarelements so that z-index works at their level. That way we avoid the z-index of a nested annotation (e.g. a linkAnnotation) "compete" with the z-index of the editToolbar.This PR also fixes a bug where a textAnnotation was rendered above the editToolbar.