Fix deprecation warnings in iOS Swift Keychain Wrapper code#5259
Fix deprecation warnings in iOS Swift Keychain Wrapper code#5259tarikeshaq merged 3 commits intomozilla:mainfrom
Conversation
And various minor code fixes
Codecov ReportBase: 44.29% // Head: 44.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5259 +/- ##
==========================================
+ Coverage 44.29% 44.30% +0.01%
==========================================
Files 175 175
Lines 13899 13898 -1
==========================================
+ Hits 6157 6158 +1
+ Misses 7742 7740 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tarikeshaq
left a comment
There was a problem hiding this comment.
Thanks for the PR @lmarceau 🙏
The CI job for iOS is failing due to a few cannot be resolved without a contextual type
You can try opening the xcode project in application-services/megazords/ios-rust/MozillaTestServices
Then running build on Xcode should show the errors!
tarikeshaq
left a comment
There was a problem hiding this comment.
Thank @lmarceau 🚀 Since this is deprecation fix/refactor we don't need a changelog so I'm landing this!
Hello! I've been seeing some warnings and deprecations while using A-S and would love to provide a fix for them. I've notice this code is based on the SwiftKeychainWrapper project, and a contributor over there fixed those warnings so this PR is based on those changes (although it's not a 1 to 1 since we have MZ prefixes on some classes).
First time contributing on this project, so not sure how to properly run this as this Swift project doesn't work the standard way I normally run things. Please let me know how I can improve this PR.
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[ff-android: firefox-android-branch-name]and/or[fenix: fenix-branch-name]to the PR title.