Fix locales job by adding missing GH_TOKEN and skipping if there are no template changes - #25350
Open
diox wants to merge 1 commit into
Open
Fix locales job by adding missing GH_TOKEN and skipping if there are no template changes#25350diox wants to merge 1 commit into
diox wants to merge 1 commit into
Conversation
…no template changes That same logic was already used in addons-frontend to skip extracting if there are no changes to the template. This avoid creating useless changes to .po files that only contain line-wrapping changes. We also need GH_TOKEN to create the PR when there are changes.
eviljeff
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That same logic was already used in addons-frontend to skip extracting if there are no changes to the template. This avoid creating useless changes to .po files that only contain line-wrapping changes (we also have that in the pushing script, and it's also useful there, but only if we also do it here to avoid merging
.pofiles and creating those extra changes).We also need GH_TOKEN to create the PR when there are changes.
Should fix the build on
master.