re-enable more ruff rules - #25339
Open
eviljeff wants to merge 1 commit into
Open
Conversation
eviljeff
force-pushed
the
00000-enable-more-ruff-rules
branch
from
August 25, 2026 09:15
7862757 to
91979d4
Compare
eviljeff
force-pushed
the
00000-enable-more-ruff-rules
branch
from
August 25, 2026 10:02
91979d4 to
1b5c387
Compare
eviljeff
marked this pull request as ready for review
August 25, 2026 10:21
eviljeff
requested review from
a team and
nothingrandom
and removed request for
a team
August 25, 2026 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from mozilla/addons#16365
Description
Removes more ignored ruff rules so we're (somewhat) closer to the standard list of ruff formatting/linting rules.
Context
Method: Starting at the bottom of the ignore list - so we can remove the most number of exceptions with the fewest lines of change - I've been removing rules in batches, then asking Claude to fix, then checking the result to see if it makes sense to me. This pr is the bottom 30 rules, excluding the INT rules, because they relate to localized strings and they could be changing in the next 3 months anyway with pinguino.
Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.