Skip to content

Add an (author only) AddonViewSet list function - #25318

Open
eviljeff wants to merge 1 commit into
mozilla:masterfrom
eviljeff:16378-addons-my-addons-list
Open

Add an (author only) AddonViewSet list function#25318
eviljeff wants to merge 1 commit into
mozilla:masterfrom
eviljeff:16378-addons-my-addons-list

Conversation

@eviljeff

@eviljeff eviljeff commented Aug 18, 2026

Copy link
Copy Markdown
Member

Fixes mozilla/addons#16378

Description

Enables GET on /api/v5/addons/addon/ to list all the add-ons the user is an author of. Also implements ?sort= and ?type= to match functionality on existing devhub

Context

  • name is omitted from a possible sort, after talking with Mat (perf concerns).
  • all sort parameters default to ascending and can be made descending with a - prefix, e.g. ?sort=-created, which is different to the /addons/search/ endpoint, which only supports descending (i.e. sort=created is already descending, and can't be reversed to ascending). The sort options also match the detail field naming (e.g. average_daily_users rather than users)

Testing

It's a little annoying to test, because by definition you need auth

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff
eviljeff force-pushed the 16378-addons-my-addons-list branch 3 times, most recently from 67e6d41 to 1a3ff9c Compare August 20, 2026 11:53
@eviljeff
eviljeff marked this pull request as ready for review August 20, 2026 11:58
@eviljeff
eviljeff force-pushed the 16378-addons-my-addons-list branch from 1a3ff9c to f03be4f Compare August 20, 2026 12:00
@eviljeff
eviljeff requested review from a team and nothingrandom and removed request for a team August 20, 2026 15:21
Comment on lines +154 to +163
======================== ====================================================
average_daily_users Average number of daily users.
bayesian_rating Bayesian rating.
created Creation date.
hotness Hotness (average number of users progression).
id Numeric add-on id on AMO.
last_updated Last updated date.
ratings.bayesian_average Alias of bayesian_rating, to match detail structure.
weekly_downloads Number of weekly downloads.
======================== ====================================================

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have some questions as an end user to some of these;

average_daily_users, hotness, and weekly_downloads I'd expect to look similar
bayesian_rating and ratings.bayesian_average -> is this the star rating for the addon?
last_updated -> does this go for the updated approved, or updated uploaded?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They match the fields in the detail section for consistency - do those fields need further explanation? And/or a sentence explaining the connection?

I'd expect to look similar

Not sure what you mean here - that the naming is self explanatory or you think they're obsolete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Add API to list add-ons for the current user

2 participants