Remove default type as Elastic 7 deprecates document types#527
Open
deric wants to merge 2 commits intomozilla-services:mainfrom
Open
Remove default type as Elastic 7 deprecates document types#527deric wants to merge 2 commits intomozilla-services:mainfrom
deric wants to merge 2 commits intomozilla-services:mainfrom
Conversation
Contributor
|
Changing the defaults is a breaking change for anyone using pre v7. Ideally the encoder would accept a version and then apply the correct defaults (the version should default to 5 (when nil) since that is what this encoder was originally created against). Also the elasticsearch package version needs to be incremented 1.0.9 |
See: https://www.elastic.co/guide/en/elasticsearch/reference/7.x/removal-of-types.html `_doc` is a dummy document type that will work as well with older Elastic versions
Author
|
@trink You're right, it would be a breaking change for anyone relying on default values. I wasn't sure how to get the Elastic version, alternatively we could send |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be compatible with recent Elastic versions document type information should not be defined or
_doctype could be used._docis a dummy document type that will work as well with older Elastic versionsSee: https://www.elastic.co/guide/en/elasticsearch/reference/7.x/removal-of-types.html