Skip to content

Consider pruning property in Connect stage#742

Open
rhaschke wants to merge 5 commits intomoveit:masterfrom
ubi-agni:fix-#737
Open

Consider pruning property in Connect stage#742
rhaschke wants to merge 5 commits intomoveit:masterfrom
ubi-agni:fix-#737

Conversation

@rhaschke
Copy link
Copy Markdown
Contributor

Even if pruning was disabled, pruning could sneak in via the Connect stage.
For now fixes #737.

For me, the added unit test failed with an assertion failure, because the state copied from the Fallback to the next child was PRUNED and not ENABLED:

assert(it->priority_.enabled());

Even if pruning was disabled, pruning could sneak in via the Connect stage.
Previously, it was explicitly disabled in Task's constructor.
Child containers inherited the setting from their parent, i.e. ultimately the task.
However, this meant that the property remained undefined for standalone containers.

Now, the default value is declared in each container.
Additionally, the property is still inherited from the parent.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52.89%. Comparing base (c13fe5c) to head (666e7f3).

Files with missing lines Patch % Lines
core/src/container.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   52.85%   52.89%   +0.05%     
==========================================
  Files         138      138              
  Lines       10628    10641      +13     
  Branches     1127     1128       +1     
==========================================
+ Hits         5616     5628      +12     
- Misses       5004     5005       +1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fallback skips subsequent childs when a connect stage inside a child container fails.

1 participant