Consider pruning property in Connect stage#742
Open
rhaschke wants to merge 5 commits intomoveit:masterfrom
Open
Consider pruning property in Connect stage#742rhaschke wants to merge 5 commits intomoveit:masterfrom
rhaschke wants to merge 5 commits intomoveit:masterfrom
Conversation
Even if pruning was disabled, pruning could sneak in via the Connect stage.
Previously, it was explicitly disabled in Task's constructor. Child containers inherited the setting from their parent, i.e. ultimately the task. However, this meant that the property remained undefined for standalone containers. Now, the default value is declared in each container. Additionally, the property is still inherited from the parent.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #742 +/- ##
==========================================
+ Coverage 52.85% 52.89% +0.05%
==========================================
Files 138 138
Lines 10628 10641 +13
Branches 1127 1128 +1
==========================================
+ Hits 5616 5628 +12
- Misses 5004 5005 +1
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if pruning was disabled, pruning could sneak in via the Connect stage.
For now fixes #737.
For me, the added unit test failed with an assertion failure, because the state copied from the Fallback to the next child was
PRUNEDand notENABLED:moveit_task_constructor/core/src/storage.cpp
Line 125 in 82a1156